Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smokehouse: log out the command we spawn with #2074

Merged
merged 3 commits into from
Apr 26, 2017
Merged

Smokehouse: log out the command we spawn with #2074

merged 3 commits into from
Apr 26, 2017

Conversation

paulirish
Copy link
Member

image

Handy so you can retry the exact command to debug.

@brendankenny
Copy link
Member

is that going to be useful since most rely on the test server running?

@paulirish
Copy link
Member Author

well, for this netrecordsComputed branch i was only failing in smokehouse, and no where else.. so i needed to repro the exact situation in order to debug it.

so yes? :)

@paulirish
Copy link
Member Author

If you're interested.. also logging the static-server command now:

image

wdyt?

@brendankenny
Copy link
Member

I think that's cool, though it's pretty noisy. You couldn't just run yarn smokehouse locally?

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulirish paulirish merged commit 8b47006 into master Apr 26, 2017
@paulirish paulirish deleted the dimcmd branch April 26, 2017 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants