Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: exclude score checking and flaky link preload assertion. #2202

Merged
merged 1 commit into from
May 10, 2017
Merged

tests: exclude score checking and flaky link preload assertion. #2202

merged 1 commit into from
May 10, 2017

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented May 10, 2017 •
edited
Loading

make master green again

ref #2201

@brendankenny
Copy link
Member

why is this flaky when it wasn't before?

@paulirish
Copy link
Member Author

@brendankenny the link new isLinkPreload stuff in https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/gather/gatherers/dobetterweb/tags-blocking-first-paint.js is probably at the root here.

my guess is its racy and fails 20% of the time. and the previous travis builds for it were not running enough.

@paulirish
Copy link
Member Author

and fwiw the &isdisabled bit is just so its easier to match up which requests are what on the smokehouse output side. :)

@paulirish paulirish merged commit f0e0dfa into master May 10, 2017
@paulirish paulirish deleted the makemastergreen branch May 10, 2017 02:12
@iMakedonsky iMakedonsky mentioned this pull request Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulirish @brendankenny