add lighthouse calculation time to json results #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -38,9 +38,10 @@ const Config = require('./config/config'); | |||
| */ | |||
|
|
|||
| module.exports = function(url, flags = {}, configJSON) { | |||
| return new Promise((resolve, reject) => { | |||
| const startTime = Date.now(); | |||
There was a problem hiding this comment.
Audit error: Avoids Date.now() In Its Own Scripts ;)
|
no, that was my best effort at "timeDoingStuff" :) |
|
I guess the only confusing thing is the top-level |
|
how about a timing object: LHR.timing.total // 43752 (ms)(i imagine we'll want breakdown by pass, gather audit later on) name bikeshed: |
love |
|
|
paulirish
approved these changes
May 13, 2017
|
I'm adding this to plots/, just sec :) |
|
plots/ now graphs the total execution time for runs (and can expand as we add other timings) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
happy to bikeshed on the name and where it should be taken, but basically it would be nice to be able to track how long a lighthouse run takes. I was going to do it in plots/, but @wwwillchen pointed out that it's actually a generally useful thing to have in the LHR.
We could put this inside
runner, but it's actually kind of nice to track config and connection construction too. This does ignore work done inbin.ts, however.