Enhance error wording around busy traces. #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
suggested changes
May 13, 2017
| @@ -26,7 +26,8 @@ const MIN_TASK_CLUSTER_PADDING = 1000; | |||
| const MIN_TASK_CLUSTER_FMP_DISTANCE = 5000; | |||
|
|
|||
| const MAX_QUIET_WINDOW_SIZE = 5000; | |||
| const TRACE_BUSY_MSG = 'trace was busy the entire time'; | |||
| const TRACE_BUSY_MSG = 'The main thread was busy for the entire trace recording. ' + | |||
| 'First Interactive requires the main thread to reach a more idle state.'; | |||
There was a problem hiding this comment.
nit: 'a more idle state' feels weird, can we say 'idle for several seconds' or something?
There was a problem hiding this comment.
sgtm. done.
fixed tests too
paulirish
force-pushed
the
tracebusywording
branch
from
105f6b3
to
c9a4ef8
Compare
patrickhulce
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make these more understandable: