add custom audit recipe #2255
Merged
add custom audit recipe #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
force-pushed
the
customrecipe
branch
2 times, most recently
from
e6ad766
to
d6c75f7
Compare
brendankenny
force-pushed
the
customrecipe
branch
from
d6c75f7
to
bd00d2f
Compare
ebidel
approved these changes
May 16, 2017
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| // Run our tests along with all the default Lighthouse tests. |
There was a problem hiding this comment.
"Run your custom tests...."
| 'searchable-audit' | ||
| ], | ||
|
|
||
| // Create a new 'My site metrics' section in the default report for our results. |
There was a problem hiding this comment.
How about a 1., 2., 3., 4. on these.
docs/recipes/custom-audit/readme.md
Outdated
|
|
||
| This Lighthouse [gatherer](searchable-gatherer.js)/[audit](searchable-audit.js) pair will take that value from the context of the page and test whether or not it stays below a test threshold. | ||
|
|
||
| The config file tells Lighthouse where to find the gatherer and audit files, when to run them, and how to incoporate their output into the Lighthouse report. |
|
I didn't get a chance to review, but I was coming here to give it a thumbs up. 🌮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a custom gatherer/audit to our recipes. Happy to bikeshed on all of this :)
No rush on landing this, but we'll be using a version of this at I/O, so get in comments if you want to influence what we show there :)