Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove TTI (alpha) from performance category #2266

Merged
merged 2 commits into from
May 16, 2017
Merged

Conversation

patrickhulce
Copy link
Collaborator

This hides TTI from being displayed but still leaves it in the audits so it will appear in the trace if --save-assets and you run with the default or with onlyAudits: ['time-to-interactive']

@patrickhulce patrickhulce changed the title fix: remove TTI from performance category fix: remove TTI (alpha) from performance category May 16, 2017
@@ -675,7 +675,6 @@ module.exports = {
{"id": "first-meaningful-paint", "weight": 5, "group": "perf-metric"},
{"id": "speed-index-metric", "weight": 1, "group": "perf-metric"},
{"id": "estimated-input-latency", "weight": 1, "group": "perf-metric"},
{"id": "time-to-interactive", "weight": 5, "group": "perf-metric"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/travis/build/GoogleChrome/lighthouse/lighthouse-cli/test/smokehouse/smokehouse.js:174
throw new Error(Config did not trigger run of expected audit ${auditName});
^
Error: Config did not trigger run of expected audit time-to-interactive
at auditNames.map.auditName (/home/travis/build/GoogleChrome/lighthouse/lighthouse-cli/test/smokehouse/smokehouse.js:174:13)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@paulirish paulirish merged commit c908e81 into master May 16, 2017
@paulirish paulirish deleted the hide_tti branch May 16, 2017 17:33
@denar90
Copy link
Contributor

denar90 commented May 16, 2017

@patrickhulce
Copy link
Collaborator Author

@denar90 we're not actually removing the logic or the audit until later (probably next week) this just hides it from the report and removes it from --perf, still getting the timestamp in the trace for a few more days is intentional :)

@denar90
Copy link
Contributor

denar90 commented May 16, 2017

I'm asking because TTI is not present in audits object which is causing some errors for pwmetrics. I'm trying to integrate the latest master from c908e81 commit.

@patrickhulce
Copy link
Collaborator Author

patrickhulce commented May 16, 2017

@denar90 yeah that's probably because you're referencing the perf.json config, if you still want to surface the old TTI you'll have to explicitly include it in your config, otherwise you can ignore errors from missing events like we do

@denar90
Copy link
Contributor

denar90 commented May 16, 2017

@patrickhulce thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants