Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow template literals in linting #2310

Merged
merged 2 commits into from May 22, 2017
Merged

Conversation

stramel
Copy link
Contributor

@stramel stramel commented May 19, 2017

Not sure if it was left out for a reason or just missed. Google's default preset has this exact quotes setting so I think it could just be removed.

@paulirish
Copy link
Member

hmm.. is our linting rejecting temp literals now? not sure what diff this is making

@paulirish paulirish closed this May 20, 2017
@paulirish paulirish reopened this May 20, 2017
@paulirish
Copy link
Member

(didn't mean to close)

@stramel
Copy link
Contributor Author

stramel commented May 20, 2017

@paulirish Hmmm, I misunderstood the point of this command however, this is still the recommended setup for quotes by eslint. Really the only thing it is allowing is the use of backtick without multi-line or variable injection. /shrug I can close or remove the quote property out of the eslint and let the google preset handle it.

@wardpeet
Copy link
Collaborator

I rather be explicit though. If you don't need the `` don't use it so I'm glad not changing it but if google preset has it we prolly should move to it too.

@paulirish
Copy link
Member

falling back to the google preset works for me. Thanks.

@paulirish paulirish merged commit ee4d93b into GoogleChrome:master May 22, 2017
@stramel stramel deleted the patch-2 branch May 22, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants