Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error to chrome extension when url is using the chrome protocol #2346

Merged
merged 2 commits into from
May 23, 2017
Merged

Add error to chrome extension when url is using the chrome protocol #2346

merged 2 commits into from
May 23, 2017

Conversation

wardpeet
Copy link
Collaborator

thanks @brendankenny
Fixes #2186
image

brendankenny
brendankenny approved these changes May 23, 2017
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! one nit and LGTM

lighthouse-extension/app/src/popup.js Outdated
@@ -28,6 +28,8 @@ const NON_BUG_ERROR_MESSAGES = {
// @see https://chromium.googlesource.com/chromium/src/+/5d1f214db0f7996f3c17cd87093d439ce4c7f8f1/chrome/common/extensions/chrome_extensions_client.cc#232
'The extensions gallery cannot be scripted': 'The Lighthouse extension cannot audit the ' +
'Chrome Web Store. If necessary, use the Lighthouse CLI to do so.',
'Cannot access a chrome': 'The Lighthouse extension cannot audit ' +
'Chrome specific urls. If necessary, use the Lighthouse CLI to do so.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Chrome-specific urls' (needs a hyphen)

(though maybe there's a better name for these pages? @paulirish)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name seems ok

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the english lesson 😆

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@paulirish paulirish merged commit 9f5a8aa into master May 23, 2017
@paulirish paulirish deleted the extension-chrome-urls branch May 23, 2017 21:43
@wardpeet wardpeet mentioned this pull request Jun 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish left review comments

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wardpeet @paulirish @brendankenny