Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump jpeg quality #2354

Merged
merged 1 commit into from
May 24, 2017
Merged

fix: bump jpeg quality #2354

merged 1 commit into from
May 24, 2017

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented May 24, 2017

related #2217

at some point recently the JPEG library used by chrome has changed so that the quality or file size is now much lower for the same quality setting which is causing smoke tests to fail if they don't use the cached download of Chrome (see https://travis-ci.org/GoogleChrome/lighthouse/jobs/235694158)

this bumps it to give roughly the same output as it does under Chrome stable but we should investigate this more and try to bisect for the cause or track it better

Copy link
Contributor

@ebidel ebidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bumps it to give roughly the same output as it does under Chrome stable but we should investigate this more and try to bisect for the cause or track it better

File a bug to track that!

@patrickhulce
Copy link
Collaborator Author

@ebidel #2217 is for looking into how it compares to other encoders and automating the tracking of it over time, do we want a separate issue to track down this specific change?

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

re #2217, we can easily install libjpeg-turbo and verify things with SSIM/our eyeballs. I do wonder if there's some build rule we didn't see that swaps in other libraries depending on platform. That would make picking a particular quality number a little harder :)

@patrickhulce
Copy link
Collaborator Author

@brendankenny yeah libjpeg-turbo is one of 3 possibilities I'm not sure under what circumstances the others get triggered would have to do some more digging

https://cs.chromium.org/chromium/src/ui/gfx/codec/jpeg_codec.cc?type=cs&l=47

@patrickhulce
Copy link
Collaborator Author

@patrickhulce patrickhulce merged commit e84530e into master May 24, 2017
@patrickhulce patrickhulce deleted the jpeg_quality branch May 24, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants