Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Calibre and WPT to Readme #2355

Merged
merged 5 commits into from
May 24, 2017
Merged

Conversation

benschwarz
Copy link
Contributor

@benschwarz benschwarz commented May 24, 2017

Adds a "Lighthouse Integrations" section to README.md that mentions Calibre and WPT.

@pmeenan, I pinched this text from the WPT about page, but thought you might have some edits you'd like to see in this PR?

readme.md Outdated

* **[Calibre](https://calibreapp.com)** Calibre is a web performance monitoring tool running Lighthouse continuously or on-demand via an API. Test using emulated devices and connection speeds from a number of geographical locations. Set budgets and improve performance with actionable guidelines.

* **[Web Page Test](https://www.webpagetest.org)** — WebPagetest is an open source project that is primarily being developed and supported by Google as part of our efforts to make the web faster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

- an [open source](https://github.com/WPO-Foundation/webpagetest) tool for measuring and analyzing the performance of web pages on real devices. Users can choose to produce a Lighthouse report alongside the analysis of WebPageTest results.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between integrations and related projects?

Related projects are extensions of Lighthouse vs projects/products that use lighthouse as one of their features? Or...something? :)

@benschwarz
Copy link
Contributor Author

what's the difference between integrations and related projects?

Related projects are extensions of Lighthouse vs projects/products that use lighthouse as one of their features? Or...something? :)

The idea is that these things run Lighthouse remotely, whereas the extensions / related projects still require setup by developers.

readme.md Outdated
@@ -229,6 +229,12 @@ yarn closure
yarn compile-devtools
```

## Lighthouse Integrations

* **[Calibre](https://calibreapp.com)** Calibre is a web performance monitoring tool running Lighthouse continuously or on-demand via an API. Test using emulated devices and connection speeds from a number of geographical locations. Set budgets and improve performance with actionable guidelines.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to settle on a hyphenation scheme, and maybe bold the related project names too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brendankenny
Copy link
Member

oh, sorry, I meant since the Calibre and WPT were getting bolded, maybe webpack-lighthouse-plugin et al should be bolded too

@benschwarz
Copy link
Contributor Author

Erm. That's what I get for editing pull requests on an iPhone 😂
Got it this time, I think

@brendankenny brendankenny merged commit 7fece8f into GoogleChrome:master May 24, 2017
@benschwarz benschwarz deleted the patch-1 branch May 24, 2017 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants