test(smokehouse): add numeric comparisons #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samccone
reviewed
May 25, 2017
| @@ -29,6 +29,7 @@ const DEFAULT_EXPECTATIONS_PATH = 'pwa-expectations'; | |||
|
|
|||
| const PROTOCOL_TIMEOUT_EXIT_CODE = 67; | |||
| const RETRIES = 3; | |||
| const NUMERICAL_EXPECTATION_REGEXP = /(<|>)(\d+)/; | |||
There was a problem hiding this comment.
/^(<|>)(\d+)$/
to tighten it up a bit.
samccone
reviewed
May 26, 2017
| * - Regular expressions | ||
| * - Strict equality | ||
| * | ||
| * @param {*} actual |
There was a problem hiding this comment.
if i am reading your code correctly..
{string|number} actual
{RegExp|string} expected
I think these are the types
There was a problem hiding this comment.
nah it can be any, the Object.is catch-all does boolean and number expectations too, objects will also be passed in but will always be false
paulirish
reviewed
May 26, 2017
| @@ -29,6 +29,7 @@ const DEFAULT_EXPECTATIONS_PATH = 'pwa-expectations'; | |||
|
|
|||
| const PROTOCOL_TIMEOUT_EXIT_CODE = 67; | |||
| const RETRIES = 3; | |||
| const NUMERICAL_EXPECTATION_REGEXP = /^(<|>)(\d+)$/; | |||
There was a problem hiding this comment.
seems like it should handle <= as people would expect it, yah?
There was a problem hiding this comment.
heh yeah I suppose you're right
paulirish
approved these changes
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #2353