Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: add notes on per runs #2410

Merged
merged 2 commits into from
Jun 1, 2017
Merged

readme: add notes on per runs #2410

merged 2 commits into from
Jun 1, 2017

Conversation

paulirish
Copy link
Member

No description provided.

@paulirish paulirish requested a review from ebidel May 31, 2017 18:47
Lighthouse ships with a [performance-only config](https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/config/perf.json) that you can use:

```js
const perfConfig: any = require('lighthouse/lighthouse-core/config/perf.json');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

launchChromeAndRunLighthouse to be consistent with the other example

const perfConfig = require('lighthouse/lighthouse-core/config/perf.json');`
// ...
launchChromeAndRunLighthouse(url, flags, perfConfig).then(results => {...});

docs/readme.md Outdated
@@ -28,6 +28,22 @@ launchChromeAndRunLighthouse('https://example.com', flags).then(results => {
});
```

## Performance-only Lighthouse run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use h3: ###

docs/readme.md Outdated
lighthouse(url, flags, perfConfig)
```

You can also craft your own config (e.g. [plots.json](https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/config/plots.json)) for completely custom runs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulirish
Copy link
Member Author

sg. done.

[skip ci]
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebidel ebidel merged commit 53721a8 into master Jun 1, 2017
@ebidel ebidel deleted the paulirish-patch-1-1 branch June 1, 2017 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants