Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove aggregations #2426

Merged
merged 1 commit into from
Jun 5, 2017
Merged

remove aggregations #2426

merged 1 commit into from
Jun 5, 2017

Conversation

brendankenny
Copy link
Member

part of #2276

it is time to say goodbye :)

@brendankenny
Copy link
Member Author

the diff on runner-test.js looks like more is changing than actually is.

?w=1 makes it clearer that it's just one test being removed and one test switching from a config with an aggregation to one with a category

ebidel
ebidel approved these changes Jun 3, 2017
View reviewed changes
Copy link
Contributor

@ebidel ebidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We can probably close #1463 as well.

@paulirish
Copy link
Member

ya got some conflicts now :)

@brendankenny
Copy link
Member Author

all ✅ and travis says 💚 so farewell aggregations

@brendankenny brendankenny merged commit 90e13ac into master Jun 5, 2017
@brendankenny brendankenny deleted the rmaggregations branch June 5, 2017 22:54
@brendankenny
Copy link
Member Author

(note: aggregations died on the way back to their home planet)

@paulirish
Copy link
Member

best best.

@stramel
Copy link
Contributor

stramel commented Jun 6, 2017

6k deletions 😂😂😂

@paulirish paulirish mentioned this pull request Jun 6, 2017
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

@ebidel ebidel ebidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brendankenny @paulirish @stramel @ebidel