fix: better debug message for missing network times #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
reviewed
Jun 7, 2017
| @@ -38,6 +36,10 @@ class NetworkThroughput extends ComputedArtifact { | |||
| return boundaries; | |||
| }, []).sort((a, b) => a.time - b.time); | |||
|
|
|||
| if (!timeBoundaries.length) { | |||
There was a problem hiding this comment.
can you document this in the jsdoc?
brendankenny
requested changes
Jun 7, 2017
| @@ -193,6 +193,12 @@ class CategoryRenderer { | |||
| const descriptionEl = this._dom.createChildOf(element, 'div', 'lh-perf-hint__description'); | |||
| descriptionEl.appendChild(this._dom.convertMarkdownLinkSnippets(audit.result.helpText)); | |||
|
|
|||
| if (audit.result.debugString) { | |||
There was a problem hiding this comment.
what is this adding that wasn't there before? Not clear from the screenshot
There was a problem hiding this comment.
it was, but not if it didn't completely fail (this was sort of drive by, there are other debugStrings that can be set)
There was a problem hiding this comment.
added a test now for it
There was a problem hiding this comment.
it was, but not if it didn't completely fail
it was...what? :P
| @@ -85,7 +85,7 @@ describe('Byte efficiency base audit', () => { | |||
| {wastedBytes: 450, totalBytes: 1000, wastedPercent: 50}, | |||
| {wastedBytes: 400, totalBytes: 450, wastedPercent: 50}, | |||
| ], | |||
| }); | |||
| }, 1000); | |||
brendankenny
approved these changes
Jun 7, 2017
done |
|
travis is greeeeeen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the debug information when network throughput can't be computed and defaults the result to Infinity instead of 0 which makes more sense since the only use of networkThroughput is to be the divisor (the computed artifact is also used by total byte weight which makes sense to say 0 ms time and still report the byte savings)
This was affecting chrome URLs which don't have any timing information, results from before and after for
chrome://versionbelow (the optimized images error is for tainting canvas which apparently all chrome images do)Before
After
