Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove old TTI code #2452

Merged
merged 1 commit into from
Jun 7, 2017
Merged

refactor: remove old TTI code #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
254 changes: 0 additions & 254 deletions lighthouse-core/audits/time-to-interactive.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion lighthouse-core/config/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ module.exports = {
// 'time-to-firstbyte',
'first-interactive',
'consistently-interactive',
'time-to-interactive',
'user-timings',
'critical-request-chains',
'webapp-install-banner',
Expand Down
12 changes: 0 additions & 12 deletions lighthouse-core/lib/traces/pwmetrics-events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,18 +119,6 @@ class Metrics {
return safeGet(siExt, 'value.timings.visuallyComplete');
}
},
{
name: 'Time to Interactive (vAlpha)',
id: 'tti',
getTs: auditResults => {
const ttiExt = auditResults['time-to-interactive'].extendedInfo;
return safeGet(ttiExt, 'value.timestamps.timeToInteractive');
},
getTiming: auditResults => {
const ttiExt = auditResults['time-to-interactive'].extendedInfo;
return safeGet(ttiExt, 'value.timings.timeToInteractive');
}
},
{
name: 'First Interactive (vBeta)',
id: 'ttfi',
Expand Down
34 changes: 0 additions & 34 deletions lighthouse-core/test/audits/time-to-interactive-test.js
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions lighthouse-core/test/config/config-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,14 +304,14 @@ describe('Config', () => {
audits: [
'accessibility/color-contrast',
'first-meaningful-paint',
'time-to-interactive',
'first-interactive',
'estimated-input-latency',
],
categories: {
'needed-category': {
audits: [
{id: 'first-meaningful-paint'},
{id: 'time-to-interactive'},
{id: 'first-interactive'},
],
},
'other-category': {
Expand Down Expand Up @@ -376,7 +376,7 @@ describe('Config', () => {
extends: true,
settings: {
onlyCategories: ['performance', 'missing-category'],
onlyAudits: ['time-to-interactive', 'missing-audit'],
onlyAudits: ['first-interactive', 'missing-audit'],
},
});

Expand Down