local implementation of LogNormalDistribution #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes traceviewer from third_party/
patrickhulce
approved these changes
Jun 7, 2017
|
🔢 📈 📉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates a
lib/statistics.jsas a new home for a local implementation ofLogNormalDistribution. I didn't change the interface at all, though it may be a little silly to keep the same interface when we literally only use thecomputeComplementaryPercentilemethod. Happy to take opinions on that :)This is our last dependency on traceviewer, so also removes
third_party/traceviewer-js/. Reduceslighthouse-background.jsby about another 100KB.