Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: dashboard - identify variance over lighthouse versions #2520

Merged
merged 24 commits into from
Jul 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions plots/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ $ node measure.js --out out-123
# This will launch the charts web page in the browser
# node analyze.js {out_directory}
$ node analyze.js ./out-hello

# Generate dashboard using a parent folder with multiple batch results
$ node generate-dashboard.js out-parent-folder

# Or you can specify each batch result explicitly
$ node generate-dashboard.js out-1 out-2 out-3


```

### Advanced usage
Expand Down
125 changes: 125 additions & 0 deletions plots/dashboard/dashboard.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
/**
* @license Copyright 2017 Google Inc. All Rights Reserved.
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
*/

* {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

box-sizing: border-box;
}

:root {
--header-height: 60px;
--primary-color: #3367d6;
--form-color: #333;
--overlay-offset: 50px;
}

body {
font-family: "Roboto",
-apple-system,
BlinkMacSystemFont,
"Segoe UI",
"Oxygen",
"Ubuntu",
"Cantarell",
"Fira Sans",
"Droid Sans",
"Helvetica Neue",
sans-serif;
color: #555;
width: 100%;
margin-top: calc(var(--header-height) + 35px);
}

#nav {
position: fixed;
top: 0;
left: 0;
height: var(--header-height);
width: 100%;
color: white;
padding: 15px;
font-size: 16px;
background-color: var(--primary-color);
box-shadow: 0 2px 4px rgba(0, 0, 0, .28);
z-index: 1;
}

.notes {
margin-top: -10px;
flex-direction: column;
padding-left: 20px;
font-size: 12px;
font-style: italic;
display: inline-flex;
}

.title {
font-size: 1.5rem;
}

.dth-select {
background-image: url(./dropdown_lt_2x.png);
color: var(--form-color);
background-color: #fff;
-webkit-appearance: none;
border-color: rgba(0, 0, 0, 0.2);
position: relative;
background-size: 12px 12px;
background-repeat: no-repeat;
background-position: right 6px center;
padding-left: 4px;
padding-right: 24px;
font-size: 12px;
line-height: 16px;
}

.select-metric {
padding-left: 24px;
font-size: 0.9rem;
}

.plot-container.plotly {
margin: -25px;
}

.dth-button {
left: 0;
position: absolute;
top: 35px;
cursor: pointer;
color: var(--primary-color);;
background-color: #fff;
border-color: rgba(0, 0, 0, 0.2);
padding: 3px 12px;
font-weight: 600;
-webkit-appearance: none;
margin: 0;
outline: 0;
height: 24px;
font-size: 12px;
line-height: 16px;
border: 1px solid;
border-radius: 2px;
}

#overlay {
position: absolute;
width: 100%;
height: 100vh;
top: 0;
background: #e3f2f7;
}

#overlay .close-button {
position: absolute;
top: calc(var(--header-height) + 30px);
left: var(--overlay-offset);;
}

#overlay .chart {
position: absolute;
top: calc(var(--header-height) + 100px);
left: var(--overlay-offset);;
}
252 changes: 252 additions & 0 deletions plots/dashboard/dashboard.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,252 @@
/**
* @license Copyright 2017 Google Inc. All Rights Reserved.
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
*/
'use strict';

/* global Plotly, dashboardResults */
/* eslint-env browser */

class Dashboard {
constructor(metrics, charts) {
this._charts = charts;
this._currentMetric = metrics[0];
this._numberOfBatchesToShow = 0;
this._initializeSelectMetricControl(metrics);
this._initializeSelectNumberOfBatchesToShow();
}

render() {
this._charts.render(this._currentMetric, this._numberOfBatchesToShow);
}

_initializeSelectMetricControl(metrics) {
const metricsControl = document.getElementById('select-metric');
for (const metric of metrics) {
const option = document.createElement('option');
option.label = metric;
option.value = metric;
metricsControl.appendChild(option);
}
metricsControl.addEventListener('change', e => this._onSelectMetric(e), false);
}

_onSelectMetric(event) {
this._currentMetric = event.target.value;
this.render();
}

_initializeSelectNumberOfBatchesToShow() {
const control = document.getElementById('select-number-of-batches');
control.addEventListener('change', e => this._onSelectNumberOfBatchesToShow(e), false);
}

_onSelectNumberOfBatchesToShow(event) {
if (event.target.value === 'all') {
this._numberOfBatchesToShow = 0;
} else {
this._numberOfBatchesToShow = parseInt(event.target.value, 10);
}
this.render();
}
}

class Charts {
constructor(renderingScheduler) {
this._renderingScheduler = renderingScheduler;
this._elementId = 1;
this._layout = {
width: 400,
height: 300,
xaxis: {
showgrid: false,
zeroline: false,
tickangle: 60,
showticklabels: false
},
yaxis: {
zeroline: true,
rangemode: 'tozero'
},
showlegend: false,
titlefont: {
family: `"Roboto", -apple-system, BlinkMacSystemFont, sans-serif`,
size: 14
}
};
}

render(currentMetric, numberOfBatchesToShow) {
Utils.removeChildren(document.getElementById('charts'));
for (const [metricName, site] of Object.entries(dashboardResults[currentMetric])) {
const percentiles = Object.entries(site)
.map(([batchName, batch]) => {
return {
x: batchName,
higher: Utils.calculatePercentile(batch.map(metric => metric.timing), 0.8),
median: Utils.calculatePercentile(batch.map(metric => metric.timing), 0.5),
lower: Utils.calculatePercentile(batch.map(metric => metric.timing), 0.2)
};
})
.slice(-1 * numberOfBatchesToShow);

const median = {
x: percentiles.map(r => r.x),
y: percentiles.map(r => r.median),
type: 'scatter',
mode: 'line',
name: 'median'
};

const errorBands = {
x: percentiles.map(r => r.x).concat(percentiles.map(r => r.x).reverse()),
y: percentiles.map(r => r.higher).concat(percentiles.map(r => r.lower).reverse()),
fill: 'toself',
fillcolor: 'rgba(0,176,246,0.2)',
line: {color: 'transparent'},
name: 'error bands',
showlegend: false,
type: 'scatter'
};
this._renderPreviewChart([median, errorBands], metricName);
}
}

_renderPreviewChart(data, title) {
this._renderingScheduler.enqueue(_ => {
Plotly.newPlot(
this._createPreviewChartElement(data, title),
data,
Object.assign({title}, this._layout)
);
});
}

_createPreviewChartElement(data, title) {
const chart = document.createElement('div');
chart.style = 'display: inline-block; position: relative';
chart.id = 'chart' + this._elementId++;

const button = document.createElement('button');
button.className = 'dth-button show-bigger-button';
button.appendChild(document.createTextNode('Focus'));
button.addEventListener('click', () => this._onFocusChart(data, title), false);
chart.appendChild(button);

const container = document.getElementById('charts');
container.appendChild(chart);
return chart.id;
}

_onFocusChart(data, title) {
const overlay = document.createElement('div');
overlay.id = 'overlay';
document.body.appendChild(overlay);

document.getElementById('charts').style.display = 'none';

const closeButton = document.createElement('button');
closeButton.className = 'dth-button close-button';
closeButton.appendChild(document.createTextNode('Close'));
closeButton.addEventListener('click', onCloseFocusedChart, false);
overlay.appendChild(closeButton);

const chart = document.createElement('div');
chart.className = 'chart';
overlay.appendChild(chart);
this._renderFocusedChart(data, title, chart);

function onCloseFocusedChart() {
document.getElementById('charts').style.display = 'block';
document.body.removeChild(overlay);
}
}

_renderFocusedChart(data, title, element) {
Plotly.newPlot(
element,
data,
Object.assign({title}, this._layout, {
width: document.body.clientWidth - 100,
height: 500
})
);
}
}

class RenderingScheduler {
constructor() {
this._queue = [];
}

enqueue(fn) {
const isFirst = this._queue.length == 0;
this._queue.push(fn);
if (isFirst) {
this._render();
}
}

_render() {
window.requestAnimationFrame(_ => {
const plotFn = this._queue.shift();
if (plotFn) {
plotFn();
this._render();
}
});
}
}

const Utils = {
/**
* @param {!Element} parent
*/
removeChildren(parent) {
while (parent.firstChild) {
parent.removeChild(parent.firstChild);
}
},

/**
* Calculate the value at a given percentile
* Based on: https://gist.github.com/IceCreamYou/6ffa1b18c4c8f6aeaad2
* @param {!Array<number>} array
* @param {number} percentile should be from 0 to 1
*/
calculatePercentile(array, percentile) {
const sorted = array.filter(x => x !== null).sort((a, b) => a - b);

if (sorted.length === 0) {
return 0;
}
if (sorted.length === 1 || percentile <= 0) {
return sorted[0];
}
if (percentile >= 1) {
return sorted[sorted.length - 1];
}

const index = (sorted.length - 1) * percentile;
const lower = Math.floor(index);
const upper = lower + 1;
const weight = index % 1;

return sorted[lower] * (1 - weight) + sorted[upper] * weight;
}
};

function main() {
/**
* Navigation Start is usually not a very informative metric.
*/
const metrics = Object.keys(dashboardResults).filter(m => m !== 'Navigation Start');

const renderingScheduler = new RenderingScheduler();
const charts = new Charts(renderingScheduler);
const dashboard = new Dashboard(metrics, charts);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiiiice muuuuch easier to follow!

minor nit, personally I like to separate the rendering logic from a constructor to an explicit render() method so it's clear what attaches to the DOM and what does basic setup and whatnot (if there's no need to keep instance variables at all some could even be static and the classes just used for logical grouping but totally up to you)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done. I'll keep the instance variables (otherwise I think I'd need to use singletons or global variables).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah wasn't implying that you should make them static, just that if it shook out without the need for instance variables didn't have to keep em that way

dashboard.render();
}

main();
Binary file added plots/dashboard/dropdown_lt_2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading