Throw better error message when url is not auditable #2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebidel
suggested changes
Jun 19, 2017
| 'are trying to review.' | ||
| 'are trying to review.', | ||
| 'Cannot access contents of the page': 'The Lighthouse extension can only audit ' + | ||
| ' http & https pages.', |
There was a problem hiding this comment.
"Lighthouse can only audit URLs that start with http:// or https://."
paulirish
approved these changes
Jun 20, 2017
|
does this actually fix #2525? The error pattern ( |
|
I think you're looking at the wrong one? the exception message is "Cannot access contents of the page. Extension manifest must request permission to access the respective host." and this PR looks for "Cannot access contents of the page" |
oh, ha, new line :) 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should throw a message that don't support non auditable pages like view-source, ...
Fixes #2525
Not sure it's the best solution though