is-on-https: check record.protocol for blob urls #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Jun 19, 2017
paulirish
approved these changes
Jun 19, 2017
| function isOnHttps() { | ||
| // Check blob URL. | ||
| const img = document.createElement('img'); | ||
| img.src = URL.createObjectURL(blob); |
There was a problem hiding this comment.
@ebidel I don't think this is actually working? Uncaught ReferenceError: blob is not defined.
The expectation after this change should have length: 2 (the current extendedInfo has http://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js in it, not the blob URL)
There was a problem hiding this comment.
Oops. Yea the smoketest wasn't testing anything. Bug prevented the image from being aded to the DOM.
Will fix.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2523.
Adds an additional check for the protocol/scheme. FWIW,
record.schemeisn't populated forblob:urls but.protocolis!