Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(domstats): prevent infinite loop #2561

Merged
merged 1 commit into from
Jun 21, 2017
Merged

fix(domstats): prevent infinite loop #2561

merged 1 commit into from
Jun 21, 2017

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Jun 21, 2017 •
edited
Loading

fixes #2532

the url was https://www.davidemaggio.it/ the parentNode.host of the html tag is the body tag and vice versa

@patrickhulce patrickhulce requested a review from ebidel June 21, 2017 20:18
@brendankenny
Copy link
Member

the parentNode of the html tag is the body tag and vice versa

I wouldn't think this would be possible, but looks like it's some ShadowRoot issue. html.parentNode is document, so it should stop there, but html.parentNode.host is the body within html, so elementPathInDOM's traversal goes back into itself.

@brendankenny
Copy link
Member

also, looks like you need to be in mobile emulation to trigger this

@ebidel
Copy link
Contributor

ebidel commented Jun 21, 2017 •
edited
Loading

Wow. Very Very strange. Maybe something to do with AMP (doesn't affect polymer sites). But I dont see a shadow root on <html> or <body>. So weird.

document.documentElement.parentNode.host should be null

cc @pbakaus

@patrickhulce patrickhulce merged commit 0aa6601 into master Jun 21, 2017
@patrickhulce patrickhulce deleted the infinite_loop_domstats branch June 21, 2017 21:37
@ryan-ally ryan-ally mentioned this pull request Mar 29, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Mar 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebidel ebidel ebidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lighthouse does not finish
3 participants
@patrickhulce @brendankenny @ebidel