Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes viewer CSS specificity and event listener removal #2575

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

brendankenny
Copy link
Member

sorry, two last viewer flubs

  1. This was an existing issue with the old viewer too: binding the message handler to this meant that a newly created function was being passed to addEventListener, so later attempts to remove the handler via a reference to the original, non-bound function was having no effect. Noticed when refreshing the viewer kept loading the same report as long as the triggering html report was still open in a tab.

  2. save-as-gist is hidden by the CSS in the <template>s, which is after viewer.css in the page, so they win. This !importants it. Why does anyone let me write CSS

@paulirish
Copy link
Member

save-as-gist is hidden by the CSS in the s, which is after viewer.css in the page, so they win.

should the templates be first in order? seems kinda more correct.

@brendankenny
Copy link
Member Author

Yeah, that makes sense, though would the CSS have to be after not only the templates but where the templates end up inserted into the DOM, too?

@paulirish
Copy link
Member

ah yes. this is correct. :) well then.. !important ftw.

@brendankenny brendankenny merged commit 05e928e into master Jun 23, 2017
@brendankenny brendankenny deleted the viewerfixes branch June 23, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants