fixes viewer CSS specificity and event listener removal #2575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry, two last viewer flubs
This was an existing issue with the old viewer too: binding the
message
handler tothis
meant that a newly created function was being passed toaddEventListener
, so later attempts to remove the handler via a reference to the original, non-bound function was having no effect. Noticed when refreshing the viewer kept loading the same report as long as the triggering html report was still open in a tab.save-as-gist is hidden by the CSS in the
<template>
s, which is after viewer.css in the page, so they win. This !importants it. Why does anyone let me write CSS