remove report v1 and dependencies #2596

brendankenny · 2017-06-26T08:07:08Z

part of #2276

also removes formatters, handlebars, handlebar build files, etc

still to do:

decide what to do with PerfX. Its UI depends on injecting a handlebars partial into the report, which no longer supports handlebars partials. Disabled while we decide on that.
move the v2 report to lighthouse-core/report/. Was too confusing to also do that in this PR :)

ebidel

Noizzzzze

ebidel · 2017-06-26T15:51:07Z

lighthouse-cli/printer.ts

@@ -8,8 +8,8 @@
 /**
 * An enumeration of acceptable output modes:
 *   'json': JSON formatted results
- *   'html': An HTML report
- *   'domhtml': An HTML report rendered client-side with DOM elements
+ *   'html': An HTML report rendered client-side with DOM elements


How about just "An HTML report". "rendered client-side with DOM elements" is an unimportant implementation detail of v1 vs v2.

ebidel · 2017-06-26T15:55:19Z

lighthouse-core/audits/byte-efficiency/total-byte-weight.js

-          }
-        },
-        details: v2TableDetails
+        details: tableDetails


Why are some audits keeping extendedInfo and others are nuking it?

Why are some audits keeping extendedInfo and others are nuking it?

removing makeV1TableHeadings was the immediate motivation, and then some that were using v2TableDetails for details but something besides a v1 table in the extendedInfo, but ended up with identical info in each...and then I probably got a little too trigger happy. I'll revert them so we can deal with slimming down LHR in a separate PR.

ebidel · 2017-06-26T16:05:20Z

lighthouse-core/test/audits/deprecations-test.js

-    assert.equal(auditResult.extendedInfo.value[0].url, URL);
-    assert.equal(auditResult.extendedInfo.value[0].label, 'line: 123');
+    assert.equal(auditResult.details.items.length, 2);
+    assert.equal(auditResult.details.items[0][1].text, URL);


ugh. we should probably rename URL while you're here. Node 8 has https://nodejs.org/api/url.html.

you still have to require it though and it's meant to be identical so why need to rename?

This is true. I suppose we'll know if someone introduces that require and things break. Just thinking ahead.

we probably should generally use lowercase url for things like that

ebidel · 2017-06-26T16:05:51Z

lighthouse-core/test/audits/dobetterweb/external-anchors-use-rel-noopener-test.js

@@ -36,7 +36,7 @@ describe('External anchors use rel="noopener"', () => {
      URL: {finalUrl: URL},


more of them.

patrickhulce

not clear to me why we're nuking extendedInfo in a lot of places/how the decision was made to nuke or keep. Those will be breaking changes if anyone was looking for information in there but maybe I'm missing the methodology?

patrickhulce · 2017-06-26T17:36:33Z

lighthouse-core/audits/consistently-interactive.js

@@ -247,8 +246,7 @@ class ConsistentlyInteractiveMetric extends Audit {
          displayValue: Util.formatMilliseconds(timeInMs),
          optimalValue: this.meta.optimalValue,
          extendedInfo: {
-            value: extendedInfo,
-            formatter: Formatter.SUPPORTED_FORMATS.NULL,
+            value: extendedInfo


why you gotta nuke the extra commas? :(

why you gotta nuke the extra commas? :(

haha, I realized what I was doing halfway through and thought that might be a mistake. I'll restore them :)

paulirish · 2017-06-26T19:17:11Z

lighthouse-cli/printer.ts

- *   'html': An HTML report
- *   'domhtml': An HTML report rendered client-side with DOM elements
+ *   'html': An HTML report rendered client-side with DOM elements
+ *   'domhtml': Alias for 'html' report.


can you also tweak the filename for domhtml files to be just .html? That's in bin.ts

brendankenny · 2017-06-26T22:07:07Z

PTAL

ebidel · 2017-06-26T22:16:02Z

Should the smoketests preserve extendedInfo for now?

brendankenny · 2017-06-26T22:20:12Z

Should the smoketests preserve extendedInfo for now?

Yeah, I guess so, though there's no details expectations on master, which are arguably more important now

brendankenny · 2017-06-26T22:31:56Z

done

brendankenny · 2017-06-28T05:17:13Z

drive-by commenters happy?

paulirish · 2017-06-28T06:16:49Z

i'm happy.

ebidel · 2017-06-28T19:03:02Z

@brendankenny you handle file move?

brendankenny · 2017-06-28T19:11:18Z

you handle file move?

got it now, thanks

patrickhulce · 2017-06-28T19:35:10Z

i'm good too

also removes formatters, handlebars, handlebar build files, etc

brendankenny · 2017-06-28T21:11:24Z

if you're developing Lighthouse, you'll also need to manually delete lighthouse-core/report/partials/ and lighthouse-core/report/templates/ as the built files in there were gitignored before and so aren't automatically deleted for you.

you'll probably also want to yarn install-all (and probably yarn build-all) to get rid of removed dependencies.

paulirish mentioned this pull request Jun 26, 2017

Operation Catharsis #2276

Closed

7 tasks

ebidel suggested changes Jun 26, 2017

View reviewed changes

patrickhulce reviewed Jun 26, 2017

View reviewed changes

paulirish reviewed Jun 26, 2017

View reviewed changes

brendankenny changed the title ~~remove report v1 and associated dependencies~~ remove report v1 and dependencies Jun 26, 2017

ebidel approved these changes Jun 26, 2017

View reviewed changes

brendankenny force-pushed the rmv1 branch from 6e9cf83 to 7f222b8 Compare June 28, 2017 19:10

brendankenny force-pushed the rmv1 branch from 7f222b8 to be57eac Compare June 28, 2017 20:34

brendankenny added 6 commits June 28, 2017 13:41

remove report v1 and associated dependencies

1b0a618

also removes formatters, handlebars, handlebar build files, etc

feedback

32b590e

revert two more extendedInfos

9004117

restore extendedInfo to dbw-expectations

6af3bb2

fix bad rebase

7dc960a

test fixes for rebase

6142e31

brendankenny force-pushed the rmv1 branch from be57eac to 6142e31 Compare June 28, 2017 20:41

brendankenny merged commit fadaef9 into master Jun 28, 2017

brendankenny deleted the rmv1 branch June 28, 2017 21:07

patrickhulce mentioned this pull request Jul 10, 2017

Decide on & document stable vs. experimental properties of the LHR #2668

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove report v1 and dependencies #2596

remove report v1 and dependencies #2596

brendankenny commented Jun 26, 2017 •

edited

Loading

ebidel left a comment

ebidel Jun 26, 2017

brendankenny Jun 26, 2017

ebidel Jun 26, 2017

brendankenny Jun 26, 2017

ebidel Jun 26, 2017

patrickhulce Jun 26, 2017

ebidel Jun 26, 2017

brendankenny Jun 26, 2017

ebidel Jun 26, 2017

patrickhulce left a comment

patrickhulce Jun 26, 2017

brendankenny Jun 26, 2017

paulirish Jun 26, 2017

brendankenny Jun 26, 2017

brendankenny commented Jun 26, 2017

ebidel commented Jun 26, 2017

brendankenny commented Jun 26, 2017

brendankenny commented Jun 26, 2017

brendankenny commented Jun 28, 2017

paulirish commented Jun 28, 2017

ebidel commented Jun 28, 2017

brendankenny commented Jun 28, 2017

patrickhulce commented Jun 28, 2017

brendankenny commented Jun 28, 2017

		@@ -36,7 +36,7 @@ describe('External anchors use rel="noopener"', () => {
		URL: {finalUrl: URL},

remove report v1 and dependencies #2596

remove report v1 and dependencies #2596

Conversation

brendankenny commented Jun 26, 2017 • edited Loading

ebidel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

patrickhulce left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brendankenny commented Jun 26, 2017

ebidel commented Jun 26, 2017

brendankenny commented Jun 26, 2017

brendankenny commented Jun 26, 2017

brendankenny commented Jun 28, 2017

paulirish commented Jun 28, 2017

ebidel commented Jun 28, 2017

brendankenny commented Jun 28, 2017

patrickhulce commented Jun 28, 2017

brendankenny commented Jun 28, 2017

brendankenny commented Jun 26, 2017 •

edited

Loading