[cli] Move bin.ts core into -cli/run.ts #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Jun 27, 2017
|
needs a |
dengm129
approved these changes
Jun 27, 2017
|
need a rebase (not sure whats going on with codecov) |
brendankenny
requested changes
Jun 27, 2017
|
|
||
| return handleError(err); | ||
| } | ||
| } |
lighthouse-cli/test/cli/run-test.js
Outdated
| @@ -0,0 +1,35 @@ | |||
| /** | |||
| * @license Copyright 2016 Google Inc. All Rights Reserved. | |||
lighthouse-cli/cli-flags.ts
Outdated
| @@ -17,8 +17,10 @@ export interface Flags { | |||
| view: boolean, maxWaitForLoad: number | |||
| } | |||
|
|
|||
| export function getFlags() { | |||
| return yargs.help('help') | |||
| export function getFlags(fakeInput?: string) { | |||
There was a problem hiding this comment.
nice, but can we call the parameter something else? It seems like a legitimate use, not just for testing, so what about manualInput, manualArgv, argvString, or something something :)
|
@brendankenny sg. done. |
|
|
||
| describe('CLI run', function() { | ||
| it('runLighthouse completes a LH round trip', () => { | ||
| const url = 'chrome://version'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(partial) fix for #2601
Unblocks issues like addyosmani/webpack-lighthouse-plugin#5
No functional changes was made in this PR; it was only a copypaste party.