Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds coming soon #333

Merged
merged 4 commits into from
May 17, 2016
Merged

Adds coming soon #333

merged 4 commits into from
May 17, 2016

Conversation

paullewis
Copy link
Contributor

Fixes #332

screen shot 2016-05-17 at 3 00 51 pm

paulirish
paulirish reviewed May 17, 2016
View reviewed changes
src/aggregators/best-practices/index.js
value: true,
weight: 0,
comingSoon: true,
description: 'Payment forms marked up for with [autocomplete] attributes',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"for with" to "with"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@paulirish paulirish added the +1 label May 17, 2016
@paulirish
Copy link
Member

nailed it.

@paullewis
Copy link
Contributor Author

All I'm sayin':

screen shot 2016-05-17 at 3 44 37 pm

@paulirish
Copy link
Member

Favorite.

@paulirish paulirish merged commit ff2fcc7 into GoogleChrome:master May 17, 2016
@paullewis paullewis deleted the coming-soon branch May 17, 2016 22:52
@paulirish paulirish mentioned this pull request Feb 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paullewis @paulirish