core(bootup-time): refactor task/group iteration #3703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
reviewed
Nov 3, 2017
| }); | ||
| result.set(url, tasks); | ||
| Object.keys(taskGroups).forEach(groupName => { | ||
| taskGroups[groupName] = Math.round(taskGroups[groupName] * 10) / 10; |
There was a problem hiding this comment.
Why do you want to reduce the number after the period? and not just doing it in the table below with formatMilliseconds
There was a problem hiding this comment.
good call. nuked this.
wardpeet
approved these changes
Nov 3, 2017
done.
|
|
manually landed in 33b1574 also looks like PR destination is editable so i didnt need to do this. whoops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.