deps(axe): bump axe to latest

[paulirish]

changes here: https://github.com/dequelabs/axe-core/releases

Nothing in particular triggered me to bump, though "Prevent color rules from crashing Chrome 66+" looks certainly worthwhile. :)

[brendankenny]

some smoke test expectation changes

[paulirish]

@robdodson questions for you. we have two failures with the latest here.

1. accesskeys. fix: Update tags to accesskey & link-name rules dequelabs/axe-core#922 removed it from wcag tags, so its never included. luckily your smoketest caught this. could have been a silent failure for a while otherwise. :) since its not wcag anymore should we remove it? or explicitly include. up to you.
2. layout-table. fix(layout-table): check for presentation, none roles and isfocusable for matches dequelabs/axe-core#828 changed it's implementation and now the smoketest returns it as nonApplicable suggesting that the new matches fn doesn't match our table. I don't totally follow why... so what should we do about this?

[robdodson]

For 1 I think we should keep it but manually add it, similar to the tabindex best-practice rule that we add. I'll need to look into 2. Not sure what's going on there.

…

On Tue, Jun 26, 2018, 6:29 PM Paul Irish ***@***.***> wrote: @robdodson <https://github.com/robdodson> questions for you. we have two failures with the latest here. 1. accesskeys. dequelabs/axe-core#922 <dequelabs/axe-core#922> removed it from wcag tags, so its never included. luckily your smoketest caught this. could have been a silent failure for a while otherwise. :) since its not wcag anymore should we remove it? or explicitly include. up to you. 2. layout-table. dequelabs/axe-core#828 <dequelabs/axe-core#828> changed it's implementation and now the smoketest returns it as nonApplicable suggesting that the new matches fn <https://github.com/dequelabs/axe-core/pull/828/files#diff-b2ba0e0e11a4b5c98e4873d24a9b6442> doesn't match our table <https://github.com/GoogleChrome/lighthouse/blob/281582439dbf7a45b00e3673840f0b93542d66aa/lighthouse-cli/test/fixtures/a11y/a11y_tester.html#L129>. I don't totally follow why... so what should we do about this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5565 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBFDczxuUkH4_pC0vkoa-4Ow6cPVyJCks5uAt_qgaJpZM4U4qfN> .

[robdodson]

I think removing role=presentation could fix 2. If not, also try removing the th. I think it's testing that folks aren't using a table to lay stuff out without putting data inside of it.

[brendankenny]

Will also fix #5940