Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(network-request): cleanup DevTools property names #5606

Merged
merged 4 commits into from
Jul 2, 2018

Conversation

patrickhulce
Copy link
Collaborator

@patrickhulce patrickhulce commented Jul 2, 2018

https://www.youtube.com/watch?v=WJ9uhDzN-rA

  • Remove all the _ from the network request properties
  • Updates our existing network record fixtures to have no _
  • Removes functions that didn't need to be functions
  • Removes unused fixture and computed artifact
  • Removes web-inspector.d.ts typings

Split into 2 commits for easier (maybe?) reviewing, 1 removes the underscores, the next converts the functions and removes the web inspector types

@patrickhulce
Copy link
Collaborator Author

@brendankenny I know this is big, but it can conflict with stuff real soon if we make too many changes, so quick look would be nice :) (most of the line volume changes are to fixtures)

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
:long_cat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants