core(i18n): always use english for logs #5727
Conversation
lighthouse-core/runner.js
Outdated
| @@ -218,7 +218,7 @@ class Runner { | |||
| */ | |||
| static async _runAudit(auditDefn, artifacts, settings, runWarnings) { | |||
| const audit = auditDefn.implementation; | |||
| const status = `Evaluating: ${audit.meta.title}`; | |||
| const status = `Evaluating: ${i18n.getDisplayValue(audit.meta.title)}`; | |||
There was a problem hiding this comment.
since displayValue is a thing i dont think we should reuse that name for this.
getOriginalMessage ?
There was a problem hiding this comment.
yeah I hesitated here, original message isn't quite right either. how bout
getFormatted
toFormatted
getFormattedValue
getFormattedString
toFormattedString
There was a problem hiding this comment.
getLocaleString? reminiscent of toLocaleString but different
(I have no strong opinions)
lighthouse-core/lib/i18n.js
Outdated
| @@ -251,5 +274,7 @@ module.exports = { | |||
| getDefaultLocale, | |||
| getRendererFormattedStrings, | |||
| createMessageInstanceIdFn, | |||
| getDisplayValue, | |||
| resolveIcuMessageInstanceId, | |||
There was a problem hiding this comment.
does this need to be exported and public? could keep it _private to the file.
There was a problem hiding this comment.
yeah sure if you'd prefer :)
lighthouse-core/lib/i18n.js
Outdated
| * @return {string} | ||
| */ | ||
| function getDisplayValue(icuMessageIdOrRawString, locale) { | ||
| return MESSAGE_INSTANCE_ID_REGEX.test(icuMessageIdOrRawString) ? |
There was a problem hiding this comment.
style nit: with these really long lines the ternary gets pretty lost. IMO more readable as
if (MESSAGE_INSTANCE_ID_REGEX.test(icuMessageIdOrRawString)) {
return resolveIcuMessageInstanceId(icuMessageIdOrRawString, locale).formattedString;
}
return icuMessageIdOrRawString;(at first I thought maybe the motivation was line length but this is in the clear :)
There was a problem hiding this comment.
works for me, done
lighthouse-core/lib/i18n.js
Outdated
| * @param {LH.Locale} [locale] | ||
| * @return {string} | ||
| */ | ||
| function getDisplayValue(icuMessageIdOrRawString, locale) { |
There was a problem hiding this comment.
switch the test-utils helper to use this?
There was a problem hiding this comment.
yup, that was the goal :)
fixes what @paulirish found in #5726