core(i18n): incorporate 52 languages into messages pipeline #5781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
changed the title
brendankenny
reviewed
Aug 6, 2018
There was a problem hiding this comment.
I don't know how important it is that the LH.Locale extern is updated, but.. it is.
that's good
Oops those were sizes before our 'minification' step. dist/scripts/lighthouse-background.js went from 349KB to 504KB.
you can't change the locale in the extension or devtools yet. Should we exclude from the bundle for now?
lighthouse-core/lib/locales/index.js
Outdated
| 'vi': require('./vi.json'), | ||
| 'zh-CN': require('./zh-CN.json'), | ||
| 'zh-HK': require('./zh-HK.json'), | ||
| 'zh-TW': require('./zh-TW.json'), |
There was a problem hiding this comment.
on looking more, it seems like we should have a 'zh' that uses 'zh-CN', but we can investigate more
brendankenny
approved these changes
Aug 7, 2018
| @@ -64,6 +64,7 @@ function getFlags(manualArgv) { | |||
| ], | |||
| 'Configuration:') | |||
| .describe({ | |||
| // We don't allowlist specific locales. Why? So we can support the user who requests 'es-MX' (unsupported) and we'll fall back to 'es' (supported) | |||
There was a problem hiding this comment.
we might want a command for listing available locales, but something for another day :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picking up on #5780...
Overview
en-IE, which we're treating like aen-GB(eg. "Minimise" instead of "Minimize"). This makes sure these locales get localized number formatting and not american style.LH.Localeextern is updated, but.. it is.FWIW:
Our bundle size forThere's a couple optimizations we could make to improve that.lighthouse-backgroundwas 1.5MB before we started i18n. Once we had en-us/en-XA/ar-XB, it was 1.6MB. With all these locales, it's now 2.5MB.Oops those were sizes before our 'minification' step.
dist/scripts/lighthouse-background.jswent from 349KB to 504KB.