core(redirects): update to modern opportunity details type #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're going to make a |
|
@paulirish updated, LMKWYT |
brendankenny
reviewed
Aug 7, 2018
| * @param {LH.Flags=} flags | ||
| * @param {LH.Config.Json|undefined} configJSON | ||
| * @param {LH.Config.Json=} configJSON |
There was a problem hiding this comment.
these (and below in runner) were some drive by fixes I noticed since the test is calling index.js directly, and the URL is now optional (in auditMode) after #5495
paulirish
commented
Aug 7, 2018
|
|
||
| /* eslint-env jest */ | ||
|
|
||
| describe.only('Default Config', () => { |
|
LGTM |
brendankenny
approved these changes
Aug 7, 2018
There was a problem hiding this comment.
Approving for @paulirish cause sharing a PR is apparently real weird now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5778
seems like this was accidentally left out of #5296 and we didn't catch it.
but the real question is: where should this test go?