-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(driver): add check to make sure Runtime.evaluate result exists #6089
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8034287
Added check to make sure Protocol Runtime evaluate result exists.
exterkamp 6385308
Changed result to response. Added an else to the else-if chain.
exterkamp e865db1
Refactored order of checking response properties.
exterkamp 75bbef5
Added return to reject.
exterkamp 1a6d0fb
Changed wording of comments and exceptions.
exterkamp dc13d34
Added backticks!
exterkamp 6f17f8d
Changed wording on response error msg.
exterkamp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -311,15 +311,24 @@ class Driver { | |
contextId, | ||
}; | ||
|
||
this.sendCommand('Runtime.evaluate', evaluationParams).then(result => { | ||
this.sendCommand('Runtime.evaluate', evaluationParams).then(response => { | ||
clearTimeout(asyncTimeout); | ||
const value = result.result.value; | ||
|
||
if (result.exceptionDetails) { | ||
if (response.exceptionDetails) { | ||
// An error occurred before we could even create a Promise, should be *very* rare | ||
reject(new Error('an unexpected driver error occurred')); | ||
} if (value && value.__failedInBrowser) { | ||
reject(Object.assign(new Error(), value)); | ||
return reject(new Error('an unexpected driver error occurred')); | ||
} | ||
|
||
// Protocol should always return a 'result' object, but it is sometimes undefined | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
// see https://github.com/GoogleChrome/lighthouse/issues/6026 | ||
if (response.result === undefined) { | ||
return reject(new Error('Driver did not sent a result object')); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
|
||
const value = response.result.value; | ||
|
||
if (value && value.__failedInBrowser) { | ||
return reject(Object.assign(new Error(), value)); | ||
} else { | ||
resolve(value); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change this text. how about this?
`Evaluation exception: ${response.exceptionDetails.text}`