misc(locales): ignore all locales from devtools & extension build #6170
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| /** | ||
| * @license Copyright 2018 Google Inc. All Rights Reserved. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
| */ | ||
| 'use strict'; | ||
|
|
||
| const lighthouse = require('../../../lighthouse-core/index'); | ||
| const background = require('./lighthouse-background'); | ||
|
|
||
| const log = require('lighthouse-logger'); | ||
| const assetSaver = require('../../../lighthouse-core/lib/asset-saver.js'); | ||
| const LHError = require('../../../lighthouse-core/lib/lh-error.js'); | ||
|
|
||
| /** @type {Record<'mobile'|'desktop', LH.Config.Json>} */ | ||
| const LR_PRESETS = { | ||
| mobile: require('../../../lighthouse-core/config/lr-mobile-config'), | ||
| desktop: require('../../../lighthouse-core/config/lr-desktop-config'), | ||
| }; | ||
|
|
||
| /** @typedef {import('../../../lighthouse-core/gather/connections/connection.js')} Connection */ | ||
|
|
||
| /** | ||
| * Run lighthouse for connection and provide similar results as in CLI. | ||
| * @param {Connection} connection | ||
| * @param {string} url | ||
| * @param {LH.Flags} flags Lighthouse flags, including `output` | ||
| * @param {{lrDevice?: 'desktop'|'mobile', categoryIDs?: Array<string>, logAssets: boolean}} lrOpts Options coming from Lightrider | ||
| * @return {Promise<string|Array<string>|void>} | ||
| */ | ||
| async function runLighthouseInLR(connection, url, flags, {lrDevice, categoryIDs, logAssets}) { | ||
| // Certain fixes need to kick-in under LR, see https://github.com/GoogleChrome/lighthouse/issues/5839 | ||
| global.isLightRider = true; | ||
|
|
||
| // disableStorageReset because it causes render server hang | ||
| flags.disableStorageReset = true; | ||
| flags.logLevel = flags.logLevel || 'info'; | ||
| const config = lrDevice === 'desktop' ? LR_PRESETS.desktop : LR_PRESETS.mobile; | ||
| if (categoryIDs) { | ||
| config.settings = config.settings || {}; | ||
| config.settings.onlyCategories = categoryIDs; | ||
| } | ||
|
|
||
| try { | ||
| const results = await lighthouse(url, flags, config, connection); | ||
| if (!results) return; | ||
|
|
||
| if (logAssets) { | ||
| await assetSaver.logAssets(results.artifacts, results.lhr.audits); | ||
| } | ||
| return results.report; | ||
| } catch (err) { | ||
| // If an error ruined the entire lighthouse run, attempt to return a meaningful error. | ||
| let runtimeError; | ||
| if (!(err instanceof LHError) || !err.lhrRuntimeError) { | ||
| runtimeError = { | ||
| code: LHError.UNKNOWN_ERROR, | ||
| message: `Unknown error encountered with message '${err.message}'`, | ||
| }; | ||
| } else { | ||
| runtimeError = { | ||
| code: err.code, | ||
| message: err.friendlyMessage ? | ||
| `${err.friendlyMessage} (${err.message})` : | ||
| err.message, | ||
| }; | ||
| } | ||
|
|
||
| return JSON.stringify({runtimeError}, null, 2); | ||
| } | ||
| } | ||
|
|
||
| /** @param {(status: [string, string, string]) => void} listenCallback */ | ||
| function listenForStatus(listenCallback) { | ||
| log.events.addListener('status', listenCallback); | ||
| } | ||
|
|
||
| if (typeof module !== 'undefined' && module.exports) { | ||
| // Export for importing types into popup.js, require()ing into unit tests. | ||
| module.exports = { | ||
| getDefaultCategories: background.getDefaultCategories, | ||
| runLighthouseInLR, | ||
| listenForStatus, | ||
| }; | ||
| } | ||
|
|
||
| // Expose on window for extension, other browser-residing consumers of file. | ||
| if (typeof window !== 'undefined') { | ||
| // @ts-ignore | ||
| window.runLighthouseInLR = runLighthouseInLR; | ||
| // @ts-ignore | ||
| window.getDefaultCategories = background.getDefaultCategories; | ||
|
There was a problem hiding this comment. do I need to expose this one? There was a problem hiding this comment. nah you can remove it and the listen fn |
||
| // @ts-ignore | ||
| window.listenForStatus = listenForStatus; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can drop this