tests: remove more mock computed artifacts #6195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Oct 9, 2018
| @@ -28,19 +28,4 @@ describe('Performance: speed-index audit', () => { | |||
| assert.equal(result.rawValue, 605); | |||
| }); | |||
| }, 10000); | |||
|
|
|||
| it('scores speed index of 845 as 100', () => { | |||
There was a problem hiding this comment.
the test above already tests that a score of 605 yields a passing score. This seemed redundant (and difficult to fake)
brendankenny
commented
Oct 9, 2018
| timing = {...networkRecord.timing}; | ||
| if (timing.requestTime === undefined) { | ||
| timing.requestTime = networkRecord.startTime || 0; | ||
| } |
There was a problem hiding this comment.
a few tweaks to get this to work well with existing tests. e.g. not overwriting timing or initiator as tests sometimes reuse the object and expect it to be unchanged
Oh, and remember that all the const artifacts = Object.assign(Runner.instantiateComputedArtifacts(), {
// ...
});after the refactor will become just const artifacts = {
// ...
};noisy but keeps the tests passing without a 2000 line PR or whatever :) |
exterkamp
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #6171, using the
networkRecordsToDevtoolsLogutility and passing in the resulting devtoolsLog instead of mocking network records directly. Also removed some other low hangingrequest*()mocks in these files.Sorry for the test noise :)