Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: remove dependency on WebInspector #6209

Merged
merged 9 commits into from
Oct 23, 2018
Merged

core: remove dependency on WebInspector #6209

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ac68e4b
core: remove DevTools dependency from font-size gatherer
patrickhulce Oct 10, 2018
9e465d0
remove the web inspector!!!
patrickhulce Oct 10, 2018
33cf19e
tests
patrickhulce Oct 10, 2018
797271d
yarn updates
patrickhulce Oct 10, 2018
aced555
feedback
patrickhulce Oct 10, 2018
702258f
feedback
patrickhulce Oct 12, 2018
377c910
Merge branch 'master' into remove_devtools
patrickhulce Oct 17, 2018
707c625
feedback
patrickhulce Oct 17, 2018
45c517e
more feedback
patrickhulce Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .prettierrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
printWidth: 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the very least this should be under lighthouse-core/test/ :P

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough, only a matter of time now anyway
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

trailingComma: "es5"
tabWidth: 2
semi: true
singleQuote: true
bracketSpacing: false
Loading