Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(proto): convert int32's into DoubleValue in proto #6332

Merged
merged 4 commits into from
Oct 18, 2018
Merged

misc(proto): convert int32's into DoubleValue in proto #6332

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e378b4
Converted benchmark_index to double.
exterkamp Oct 17, 2018
4545173
Changed on the other end! Cast benchmark idx to int.
exterkamp Oct 17, 2018
1a9902a
Converted int32's to double.
exterkamp Oct 17, 2018
ba0c90c
Moved rounding to lib file. Used Math.round.
exterkamp Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighthouse-core/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class Runner {
environment: {
networkUserAgent: artifacts.NetworkUserAgent,
hostUserAgent: artifacts.HostUserAgent,
benchmarkIndex: artifacts.BenchmarkIndex,
benchmarkIndex: parseInt(artifacts.BenchmarkIndex.toString()),
exterkamp marked this conversation as resolved.
Show resolved Hide resolved
},
lighthouseVersion,
fetchTime: artifacts.fetchTime,
Expand Down
8 changes: 4 additions & 4 deletions proto/lighthouse-result.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ message LighthouseResult {
string host_user_agent = 2;

// The benchmark index that indicates rough device class
int32 benchmark_index = 3;
exterkamp marked this conversation as resolved.
Show resolved Hide resolved
google.protobuf.DoubleValue benchmark_index = 3;
}

// The environment that the audit was run in
Expand Down Expand Up @@ -110,7 +110,7 @@ message LighthouseResult {
repeated string output = 1;

// The maximum amount of time to wait for loading in ms
int32 max_wait_for_load = 2;
google.protobuf.DoubleValue max_wait_for_load = 2;

// Network throttling options
enum ThrottlingMethod {
Expand All @@ -133,7 +133,7 @@ message LighthouseResult {
// Message containing the throttling settings used in an LH configuration
message Throttling {
// The round trip time in ms
int32 rtt_ms = 1;
google.protobuf.DoubleValue rtt_ms = 1;

// The throughput in kilobytes per second
google.protobuf.DoubleValue throughput_kbps = 2;
Expand All @@ -148,7 +148,7 @@ message LighthouseResult {
google.protobuf.DoubleValue upload_throughput_kbps = 5;

// The amount of slowdown to apply to the cpu
int32 cpu_slowdown_multiplier = 6;
google.protobuf.DoubleValue cpu_slowdown_multiplier = 6;
}

// The throttling settings used
Expand Down
8 changes: 4 additions & 4 deletions proto/sample_v2_round_trip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3244,25 +3244,25 @@
"extraHeaders": null,
"gatherMode": false,
"locale": "en-US",
"maxWaitForLoad": 45000,
"maxWaitForLoad": 45000.0,
"onlyAudits": null,
"onlyCategories": null,
"output": [
"json"
],
"skipAudits": null,
"throttling": {
"cpuSlowdownMultiplier": 4,
"cpuSlowdownMultiplier": 4.0,
"downloadThroughputKbps": 1474.5600000000002,
"requestLatencyMs": 562.5,
"rttMs": 150,
"rttMs": 150.0,
"throughputKbps": 1638.4,
"uploadThroughputKbps": 675.0
},
"throttlingMethod": "devtools"
},
"environment": {
"benchmarkIndex": 1000,
"benchmarkIndex": 1000.0,
exterkamp marked this conversation as resolved.
Show resolved Hide resolved
"hostUserAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3358.0 Safari/537.36",
"networkUserAgent": "Mozilla/5.0 (Linux; Android 6.0.1; Nexus 5 Build/MRA58N) AppleWebKit/537.36(KHTML, like Gecko) Chrome/66.0.3359.30 Mobile Safari/537.36"
},
Expand Down