core: remove recoverOrThrow / err.fatal

[connorjclark]

Fixes #6298

[paulirish]

lg though i want @brendankenny's 👍 for sure

[connorjclark]

Hmm.

@brendankenny For some reason, some tests fail now. Related to the gather lifecycle. For example: 'runs gatherer lifecycle methods strictly in sequence'. Functionally, the only difference I see it one less await for a Promise that immediately resolves. But, I tried adding a dumb await Promise.resolve(); where await GatherRunner.recoverOrThrow(artifactPromise) was, tests still fail.

[connorjclark]

that promise still needs to be awaited :) updated

[brendankenny]

Sorry, I looked too quickly :) I should have said it'll have to be something like await artifactPromise.catch(() => {}); (basically the equivalent of deleting just the if (err.fatal) {throw err;} part of recoverOrThrow).

gathererResults[gatherer.name] needs to be set to the raw promise, which may resolve or reject, which will become either the artifact or an artifact error in collectArtifacts(). But the await needs to never throw so the failure of one gatherer won't prevent moving on to the next

deference

[connorjclark]

^That happened when I used GH's "apply change" feature ...

[patrickhulce]

nice!! one codebase wart removed, only 9000 to go :)

[brendankenny]

nice! ✂️ ✂️