clients: reorganize file structure and build process

[brendankenny]

fixes #6299. New file structure matches the latest version of that issue, recreated here for reference:

├── clients/
│   ├── devtools-entry.js   (could be in subdirectory but seems unnecessary)
│   ├── lightrider-entry.js
│   ├── extension/   (current top-level lighthouse-extension/)
│   |   ├── scripts/ (currently src/)
│   |   ├── styles/
│   |   ├── manifest.json
│   |   ├── popup.html
│   |   └── etc...
│   └── test/
│       ├── lightrider-entry-test.js
│       └── extension/
│          ├── extension-test.js
│          └── popup-test.js
├── build/
│   ├── build-extension.js
│   ├── bundle-builder.js
│   └── changelog-generator/   (already exists)
├── dist/   (created while building)
│   ├── lighthouse-dt-bundle.js
│   ├── lighthouse-lr-bundle.js
│   ├── extension/
│   |   └── scripts/, styles/, manifest.json, etc
│   └── extension-package
│          ├── lighthouse-3.2.0.zip
│          └── lighthouse-3.2.1.zip
├── lighthouse-cli/
├── lighthouse-core/
└── etc...

[brendankenny]

damn, pr lint change didn't work on itself :)

[brendankenny]

And not too late to bikeshed if something doesn't look right to you now

[exterkamp]

LGTM. qq: any reason it is build-all, but then test-clients? Not: test-all, or build-all-clients? To be consistent.

[brendankenny]

qq: any reason it is build-all, but then test-clients?

just dumb reasons. We could follow up by making viewer a client (it arguably is, bundling just the report generator and renderer), then it would be build-clients. I don't think we'd want it to be test-all, because that would really imply running all the tests, including over core, which yarn test sort of already handles (though it doesn't run integration tests like smokehouse, but these client tests are mostly integration tests via puppeteer...).

Meanwhile, why build-all (or build-clients) and not just build? I think because install-all came first, which was an effort to differentiate from install because we didn't want to install all deps by default. That's still kind of a concern (though the original, main reason for doing that has long disappeared), but it might be worth revisiting to simplify things.

So, all in all, someone needs to get in there and make our npm scripts sane. 55 down to like 40 or so should maybe be the goal :)

[paulirish]

You'll want to manually delete lighthouse-extension/ from your checkouts.

[bintang992]