Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc(proto): add audit_mode and timings #6363

Merged
merged 4 commits into from
Oct 23, 2018
Merged

misc(proto): add audit_mode and timings #6363

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3558ef
Add audit mode and timings.
exterkamp Oct 22, 2018
8598cf2
Update proto/lighthouse-result.proto
brendankenny Oct 23, 2018
3713d86
Updated comments from CL.
exterkamp Oct 23, 2018
cb5d19a
Update lighthouse-result.proto
exterkamp Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions proto/lighthouse-result.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,13 +206,25 @@ message LighthouseResult {
// List of the audits that were skipped, empty if all were run
// nullable list of strings
google.protobuf.Value skip_audits = 15;

// Flag indidcating this audit was audit only or not
exterkamp marked this conversation as resolved.
Show resolved Hide resolved
google.protobuf.BoolValue audit_mode = 16;
}

// The settings that were used to run this audit
ConfigSettings config_settings = 12;

// i18n info in version 1 message format
I18n i18n = 13;

// Message containing timing information about the LHR
exterkamp marked this conversation as resolved.
Show resolved Hide resolved
message Timing {
// The total time taken by the LHR
google.protobuf.DoubleValue total = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limited to only total for now on purpose, I assume?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(timing PR isn't landed yet. i got an extension test blowing up because we nuked that try/catch :)

but since it'll be landing soon....

If we excluded it, it'd be the only property we're excluding in LR.

insert 👢 in 😮

And 10 seconds later I'm all pro-excluding from the proto.. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So...keep it in or?

}

// The timing information for the LHR
Timing timing = 14;
}

// Message containing a category
Expand Down