-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: remove protocol timeout for Page.navigate #6413
Merged
brendankenny
merged 11 commits into
master
from
issue-6407-increase-page-navigate-timeout
Nov 20, 2018
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d798047
core: increase Page.navigate timeout (#6412)
connorjclark 9af14cc
disable timeout for Page.navigate
connorjclark 273166c
add comment
connorjclark e0fa246
pr changes
connorjclark 7dd175a
no ternary
connorjclark 81c00a1
edit comment
connorjclark 3c58396
innerSendCommand
connorjclark 0383285
update comment
connorjclark 175cc67
Merge branch 'master' into issue-6407-increase-page-navigate-timeout
connorjclark 6f88aaf
add tests
connorjclark c08cb46
update test
connorjclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a leading
_
and mark it with@private
(someday tsc will support it) to make it super clear it's intended for internal use