misc: fix viewer deploy #6449
Merged
misc: fix viewer deploy #6449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
reviewed
Nov 1, 2018
| ghPages.publish(distDir, { | ||
| add: true, // keep existing files | ||
| dest: 'viewer', | ||
| message: `Update viewer to lighthouse@${lighthousePackage.version}`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug introduced by #6426
Our version of the
gh-pagesnpm package was really old, but I brought over the exact same version as before because it was working so why risk it. However, #6426 also tried to usedestfrom the docs (which wasn't supported in the old version) and it tried to promisify the whole thing. That should have worked (error-first callback as the last argument), but it looks like there was some incompatibility.This PR
gh-pagespackageghPages.publishin an explicit promisegh-pagesbranch commit message thanUpdates, with the lighthouse version number in itIt took two test commits and a revert, but verified that it is working and deploying now :)