report(edge): fix support for edge #6459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR is dependant on #6456 One error is still present and that's the detail arrows which are added by the polyfill: |
wardpeet
force-pushed
the
bug/report-ui-edge
branch
from
445ce46
to
9bc377e
Compare
paulirish
requested changes
Nov 2, 2018
wardpeet
force-pushed
the
bug/report-ui-edge
branch
from
8d216ea
to
26d94ec
Compare
|
some screenshots:
|
|
there is still an issue with the tooltips which disappear to fast. Which might be better todo in another PR. |
|
doing the tooltips in a sep PR sgtm |
| @@ -123,6 +125,11 @@ | |||
| 100% { opacity: 0.6;} | |||
| } | |||
|
|
|||
| /* Edge doesn't recognize these, so we preemptively set to display:block */ | |||
| details, summary { | |||
| display: block; | |||
There was a problem hiding this comment.
That's pretty weird, will it be fixed?
paulirish
approved these changes
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Edge has some bugs related to css variables & calc function in the transform rule. Edge doesn't support
fill="hsl()"colors inside svgdemo:
http://wardpeet-filestorage.surge.sh/lh-store/pr-6459/report.html
Related Issues/PRs
#6444