Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report(css): use padding for PWA vertical border space #6972

Merged
merged 5 commits into from
Jan 14, 2019
Merged

report(css): use padding for PWA vertical border space #6972

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5aae3e7
Add padding to left of pwa badge.
exterkamp Jan 9, 2019
b75aa4b
Dedupe the props that I just deplicated on accident.
exterkamp Jan 9, 2019
d81897a
Merge branch 'master' into pwa-line-padding
exterkamp Jan 9, 2019
bc218c7
Yeah git, don't save this file. Cool.
exterkamp Jan 9, 2019
4ad3870
Change margin -> padding.
exterkamp Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lighthouse-core/report/html/report-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,12 +786,13 @@
border: 0;
}

.lh-scores-header .lh-gauge__wrapper,
.lh-scores-header .lh-gauge--pwa__wrapper {
.lh-scores-header .lh-gauge__wrapper {
margin: 0 4px;
exterkamp marked this conversation as resolved.
Show resolved Hide resolved
exterkamp marked this conversation as resolved.
Show resolved Hide resolved
}

.lh-scores-header .lh-gauge--pwa__wrapper {
margin-right: 4px;
padding-left: 3px; /* 4px - 1px border */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to subtract the border? didn't we have 9px of space before with margin-left (4) + margin-right (4) + border (1)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is currently a 9px space. I removed the 1px just to make it 4x4 even because the symmetry is pleasing. It's fair to make it 4x4 + 1px border 🤷‍♂️ I'm just brining up the concern.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe my CSS math is just off :) but isn't having only 3px of padding making the border spacing asymmetrical? or are you referring to consistent spacing between the category scores?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes the overall spacing symmetrical with the rest of the gauges. Or at least that was my intention.

border-left: 1px solid var(--report-secondary-border-color)
}

Expand Down