report: clean up more clump/group/expandable crossover noise #6982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
changed the title
paulirish
approved these changes
Jan 11, 2019
|
what a beauty. |
brendankenny
commented
Jan 11, 2019
| @@ -409,12 +395,18 @@ class CategoryRenderer { | |||
| } | |||
|
|
|||
| // Render each clump. | |||
| for (const [clumpId, clumpRefs] of clumps) { | |||
| if (clumpRefs.length === 0) continue; | |||
| for (const [clumpId, auditRefs] of clumps) { | |||
There was a problem hiding this comment.
using a loop when we have a fixed set of clumps is still kind of dumb, but manually unrolling the loop is just slightly worse, so still going with this
|
This should also make #6974 quite a bit easier (no need for |
paulirish
force-pushed
the
expandpassed-more
branch
from
6c82f88
to
bb38960
Compare
I blame Paul's cherry picking skills :P I'll fix. |
|
ok, jk, that was my fault :) |
brendankenny
force-pushed
the
expandpassed-more
branch
from
bb38960
to
744fb1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works on top of #6930
@paulirish this is how far I think the simplification can go.
Gets rid of all
expandabletrue/false business, groups and clumps that are<divs>and others that are<details>, etc. Clumps still use the group class names, but no longer userenderAuditGroupto make themselves.