core: add inline scripts to Scripts artifact

lighthouse-cli/test/smokehouse/byte-efficiency/expectations.js

@@ -30,7 +30,7 @@ module.exports = [
           overallSavingsBytes: '>45000',
           overallSavingsMs: '>500',
           items: {
-            length: 1,
+            length: 3,
           },
         },
       },

lighthouse-core/audits/byte-efficiency/unminified-javascript.js

@@ -78,20 +78,24 @@ class UnminifiedJavaScript extends ByteEfficiencyAudit {
     const items = [];
     const warnings = [];
     for (const requestId of Object.keys(artifacts.Scripts)) {
-      const scriptContent = artifacts.Scripts[requestId];
+      const scriptContentEntry = artifacts.Scripts[requestId];
+      const scriptContents = Array.isArray(scriptContentEntry) ?
+        scriptContentEntry : [scriptContentEntry];
       const networkRecord = networkRecords.find(record => record.requestId === requestId);
-      if (!networkRecord || !scriptContent) continue;
+      if (!networkRecord || !scriptContents) continue;
 
-      try {
-        const result = UnminifiedJavaScript.computeWaste(scriptContent, networkRecord);
-        // If the ratio is minimal, the file is likely already minified, so ignore it.
-        // If the total number of bytes to be saved is quite small, it's also safe to ignore.
-        if (result.wastedPercent < IGNORE_THRESHOLD_IN_PERCENT ||
-          result.wastedBytes < IGNORE_THRESHOLD_IN_BYTES ||
-          !Number.isFinite(result.wastedBytes)) continue;
-        items.push(result);
-      } catch (err) {
-        warnings.push(`Unable to process ${networkRecord.url}: ${err.message}`);
+      for (const scriptContent of scriptContents) {
+        try {
+          const result = UnminifiedJavaScript.computeWaste(scriptContent, networkRecord);
+          // If the ratio is minimal, the file is likely already minified, so ignore it.
+          // If the total number of bytes to be saved is quite small, it's also safe to ignore.
+          if (result.wastedPercent < IGNORE_THRESHOLD_IN_PERCENT ||
+            result.wastedBytes < IGNORE_THRESHOLD_IN_BYTES ||
+            !Number.isFinite(result.wastedBytes)) continue;
+          items.push(result);
+        } catch (err) {
+          warnings.push(`Unable to process ${networkRecord.url}: ${err.message}`);
+        }
       }
     }
 

lighthouse-core/gather/gatherers/scripts.js

@@ -7,6 +7,8 @@
 
 const Gatherer = require('./gatherer');
 const NetworkRequest = require('../../lib/network-request');
+const getElementsInDocumentString = require('../../lib/page-functions.js').getElementsInDocumentString; // eslint-disable-line max-len
+const URL = require('../../lib/url-shim.js');
 
 /**
  * @fileoverview Gets JavaScript file contents.
@@ -20,7 +22,7 @@ class Scripts extends Gatherer {
   async afterPass(passContext, loadData) {
     const driver = passContext.driver;
 
-    /** @type {Object<string, string>} */
+    /** @type {LH.Artifacts['Scripts']} */
     const scriptContentMap = {};
     const scriptRecords = loadData.networkRecords
       .filter(record => record.resourceType === NetworkRequest.TYPES.Script);
@@ -34,6 +36,23 @@ class Scripts extends Gatherer {
       } catch (e) {}
     }
 
+    /** @type {string[]} */
+    const inlineScripts = await driver.evaluateAsync(`(() => {
+      ${getElementsInDocumentString};
+
+      return getElementsInDocument('script')
+        .filter(meta => !meta.src && meta.text.trim())
+        .map(meta => meta.text);
+    })()`, {useIsolation: true});
+    if (inlineScripts.length) {
+      const mainResource = loadData.networkRecords.find(
+        request => URL.equalWithExcludedFragments(request.url, passContext.url));
+      if (!mainResource) {
+        throw new Error('could not locate mainResource');
+      }
+      scriptContentMap[mainResource.requestId] = inlineScripts;
+    }
+
     return scriptContentMap;
   }
 }

types/artifacts.d.ts

@@ -108,7 +108,7 @@ declare global {
       /** Set of exceptions thrown during page load. */
       RuntimeExceptions: Crdp.Runtime.ExceptionThrownEvent[];
       /** The content of all scripts loaded by the page, keyed by networkRecord requestId. */
-      Scripts: Record<string, string>;
+      Scripts: Record<string, string|string[]>;
       /** Version information for all ServiceWorkers active after the first page load. */
       ServiceWorker: {versions: Crdp.ServiceWorker.ServiceWorkerVersion[], registrations: Crdp.ServiceWorker.ServiceWorkerRegistration[]};
       /** The status of an offline fetch of the page's start_url. -1 and a explanation if missing or there was an error. */