Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: a11y category title and description #7113

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Conversation

exterkamp
Copy link
Member

Summary
This i18n's the a11y category title, description, and manual description in the default config.

Related Issues/PRs
Follow up to Patricks #6229
helps, but doesnt close: #7010

@brendankenny brendankenny changed the title i18n: a11y title and description i18n: a11y category title and description Jan 30, 2019
lighthouse-core/config/default-config.js Outdated Show resolved Hide resolved
lighthouse-core/config/default-config.js Outdated Show resolved Hide resolved
lighthouse-core/config/default-config.js Outdated Show resolved Hide resolved
@exterkamp
Copy link
Member Author

Great feedback thanks! I'll take another pass at the SEO category title & description, since they are very similar, and could be improved in similar ways.

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@brendankenny brendankenny merged commit 81c0ece into master Jan 30, 2019
@brendankenny brendankenny deleted the i18n-a11y-title branch January 30, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y i18n
2 participants