Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: seo audits; add it in Polish #7125

Closed
wants to merge 1 commit into from
Closed

i18n: seo audits; add it in Polish #7125

wants to merge 1 commit into from

Conversation

verseopl
Copy link

Summary

i18n

Ability to create reports in other languages

none
Related Issues/PRs

I think it isn't necessary

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@patrickhulce
Copy link
Collaborator

Thank you for very much your efforts and great contribution @verseopl!!

In this case, #6860 has a bit more of a complete picture of what we need to make the audits fully support i18n. You'll be glad to know that all the strings added there will be translated to polish by the Google translators very soon once it lands.

I think we'll end up going with that implementation, but your feedback and time here are very much appreciated!

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @verseopl! As @patrickhulce said, we appreciate the hard work but #6860 will soon land and add translations for all these strings. Sorry about that!

@verseopl
Copy link
Author

Ok, no problem;) I'm glad to hear that. What about other transltations e.g. dobetterweb audits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants