-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(smokehouse): refactor to enable Smokerider #7284
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
47554b1
tests(smokehouse): Refactor so that Smokerider can run smoke tests.
connorjclark 5fb69b9
Merge remote-tracking branch 'origin/master' into lr-smokerider
connorjclark 3d2b752
fix typo
connorjclark b8f4c08
default value for processForProto opts
connorjclark 2b241cd
move test dfn type to .d.ts
connorjclark 19032ca
refactor exports
connorjclark 529f45c
fix typecheck
connorjclark 38da2ec
rename
connorjclark 6671d53
Merge remote-tracking branch 'origin/master' into lr-smokerider
connorjclark c242d24
licensey
connorjclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| /** | ||
| * @license Copyright 2019 Google Inc. All Rights Reserved. | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
| */ | ||
| 'use strict'; | ||
|
|
||
| const path = require('path'); | ||
| const smokehouseDir = 'lighthouse-cli/test/smokehouse/'; | ||
|
|
||
| /** @type {Array<Smokehouse.TestDfn>} */ | ||
| const SMOKE_TEST_DFNS = [{ | ||
| id: 'a11y', | ||
| config: smokehouseDir + 'a11y/a11y-config.js', | ||
| expectations: 'a11y/expectations.js', | ||
| batch: 'parallel-first', | ||
| }, { | ||
| id: 'errors', | ||
| expectations: smokehouseDir + 'error-expectations.js', | ||
| config: smokehouseDir + 'error-config.js', | ||
| batch: 'errors', | ||
| }, { | ||
| id: 'oopif', | ||
| expectations: smokehouseDir + 'oopif-expectations.js', | ||
| config: smokehouseDir + 'oopif-config.js', | ||
| batch: 'parallel-first', | ||
| }, { | ||
| id: 'pwa', | ||
| expectations: smokehouseDir + 'pwa-expectations.js', | ||
| config: smokehouseDir + 'pwa-config.js', | ||
| batch: 'parallel-second', | ||
| }, { | ||
| id: 'pwa2', | ||
| expectations: smokehouseDir + 'pwa2-expectations.js', | ||
| config: smokehouseDir + 'pwa-config.js', | ||
| batch: 'parallel-second', | ||
| }, { | ||
| id: 'pwa3', | ||
| expectations: smokehouseDir + 'pwa3-expectations.js', | ||
| config: smokehouseDir + 'pwa-config.js', | ||
| batch: 'parallel-first', | ||
| }, { | ||
| id: 'dbw', | ||
| expectations: 'dobetterweb/dbw-expectations.js', | ||
| config: smokehouseDir + 'dbw-config.js', | ||
| batch: 'parallel-second', | ||
| }, { | ||
| id: 'redirects', | ||
| expectations: 'redirects/expectations.js', | ||
| config: smokehouseDir + 'redirects-config.js', | ||
| batch: 'parallel-first', | ||
| }, { | ||
| id: 'seo', | ||
| expectations: 'seo/expectations.js', | ||
| config: smokehouseDir + 'seo-config.js', | ||
| batch: 'parallel-first', | ||
| }, { | ||
| id: 'offline', | ||
| expectations: 'offline-local/offline-expectations.js', | ||
| config: smokehouseDir + 'offline-config.js', | ||
| batch: 'offline', | ||
| }, { | ||
| id: 'byte', | ||
| expectations: 'byte-efficiency/expectations.js', | ||
| config: smokehouseDir + 'byte-config.js', | ||
| batch: 'perf-opportunity', | ||
| }, { | ||
| id: 'perf', | ||
| expectations: 'perf/expectations.js', | ||
| config: 'lighthouse-core/config/perf-config.js', | ||
| batch: 'perf-metric', | ||
| }, { | ||
| id: 'lantern', | ||
| expectations: 'perf/lantern-expectations.js', | ||
| config: smokehouseDir + 'lantern-config.js', | ||
| batch: 'parallel-first', | ||
| }, { | ||
| id: 'metrics', | ||
| expectations: 'tricky-metrics/expectations.js', | ||
| config: 'lighthouse-core/config/perf-config.js', | ||
| batch: 'parallel-second', | ||
| }]; | ||
|
|
||
| /** | ||
| * Attempt to resolve a path relative to the smokehouse folder. | ||
| * If this fails, attempts to locate the path | ||
| * relative to the project root. | ||
| * @param {string} payloadPath | ||
| * @return {string} | ||
| */ | ||
| function resolveLocalOrProjectRoot(payloadPath) { | ||
| let resolved; | ||
| try { | ||
| resolved = require.resolve(__dirname + '/' + payloadPath); | ||
| } catch (e) { | ||
| const cwdPath = path.resolve(__dirname + '/../../../', payloadPath); | ||
| resolved = require.resolve(cwdPath); | ||
| } | ||
|
|
||
| return resolved; | ||
| } | ||
|
|
||
| /** | ||
| * @param {string} configPath | ||
| * @return {LH.Config.Json} | ||
| */ | ||
| function loadConfig(configPath) { | ||
| return require(configPath); | ||
| } | ||
|
|
||
| /** | ||
| * @param {string} expectationsPath | ||
| * @return {Smokehouse.ExpectedLHR[]} | ||
| */ | ||
| function loadExpectations(expectationsPath) { | ||
| return require(expectationsPath); | ||
| } | ||
|
|
||
| function getSmokeTests() { | ||
| return SMOKE_TEST_DFNS.map(smokeTestDfn => { | ||
| return { | ||
| id: smokeTestDfn.id, | ||
| config: loadConfig(resolveLocalOrProjectRoot(smokeTestDfn.config)), | ||
| expectations: loadExpectations(resolveLocalOrProjectRoot(smokeTestDfn.expectations)), | ||
| batch: smokeTestDfn.batch, | ||
| }; | ||
| }); | ||
| } | ||
|
|
||
| module.exports = { | ||
| SMOKE_TEST_DFNS, | ||
| getSmokeTests, | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.