misc: remove lhr-lite.d.ts #7991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Apr 5, 2019
patrickhulce
reviewed
Apr 5, 2019
types/audit.d.ts
Outdated
| extendedInfo?: {[p: string]: any}; | ||
| /** Overrides scoreDisplayMode with notApplicable if set to true */ | ||
| notApplicable?: boolean; | ||
| /** Extra information provided by some types of audits. */ |
There was a problem hiding this comment.
seems about as descriptive as details ;)
do we want to talk about how this is structured data for the renderer?
There was a problem hiding this comment.
seems about as descriptive as
details;)
Fair :)
do we want to talk about how this is structured data for the renderer?
I took a two second stab at it :)
| @@ -64,23 +70,31 @@ declare global { | |||
| export interface Product { | |||
There was a problem hiding this comment.
somewhat unrelated, but instead of duplicating should this Pick<> + extend from Result?
There was a problem hiding this comment.
somewhat unrelated, but instead of duplicating should this
Pick<>+ extend fromResult?
yeah, I was thinking about the same thing while doing this, I think it's worth trying to make it work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4867
all our output has been unified around the full LHR (and/or a subset(ish) of it via the proto), so no need for
lhr-lite.d.tsanymore.This wasn't a comprehensive adding of strings to all the properties currently missing them, just copying over anything in
lhr-lite.d.tsthat wasn't currently in any of the type files we do use.