linting fixes #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| evaluateScript(scriptStr){ | ||
| return new Promise((function(resolve, reject) { | ||
|
|
||
| evaluateScript(chrome) { /* TODO(paulirish): scriptStr parameter */ |
There was a problem hiding this comment.
@paulirish
should scriptStr be passed in the expression property below? And this appears to need chrome passed in, like profilePageLoad below, but evaluateScript doesn't appear to be called anywhere, so I wasn't sure.
There was a problem hiding this comment.
Yeah I'll take a swipe at this guy. I left it pretty incomplete and definitely not working. :)
|
ok +1 to land this we can iterate more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another update for #4
This gets
npm run lint(andnpm test) running without error. 90% whitespace changes, with a few tweaks to the eslint rules.Added two TODOs for @paulirish since I'm not entirely sure what's going on there and git blame blames him :)
There are remaining eslint warnings. I'll follow up in #4