-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): Foo integration #8035
docs(readme): Foo integration #8035
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 馃摑 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
鈩癸笍 Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! 鈩癸笍 Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat product!
readme.md
Outdated
@@ -280,6 +280,8 @@ This section details services that have integrated Lighthouse data. If you're wo | |||
|
|||
* **[Fluxguard](https://fluxguard.com/)** - Fluxguard provides website DOM change monitoring orchestrated with Google Puppeteer, and audited by Lighthouse. Fluxguard is a freemium product, with monthly monitoring of up to 75 pages for free. | |||
|
|||
* **[Foo](https://www.foo.software)** - Foo continuously captures performance audits with Lighthouse, notifies of change, and provides visualization. Users can choose to be notified via email, Slack and PagerDuty. A dashboard with charts show changes by day, week or month and provide detailed reports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the note that this is a paid product? It also isn't clear if there is any sort of free trial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing @patrickhulce. Updated in 9065b24. If you had different phrasing in mind - feel free to let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick response!
readme.md
Outdated
@@ -280,6 +280,8 @@ This section details services that have integrated Lighthouse data. If you're wo | |||
|
|||
* **[Fluxguard](https://fluxguard.com/)** - Fluxguard provides website DOM change monitoring orchestrated with Google Puppeteer, and audited by Lighthouse. Fluxguard is a freemium product, with monthly monitoring of up to 75 pages for free. | |||
|
|||
* **[Foo](https://www.foo.software)** - Foo continuously captures performance audits with Lighthouse, notifies of change, and provides visualization. Users can choose to be notified via email, Slack and PagerDuty. A dashboard with charts show changes by day, week or month and provide detailed reports. Foo is a paid service available with tiers of pricing. Free trials aren't offered at this time, but a [demo dashboard](https://www.foo.software/demo/dashboard) is publicly available for viewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **[Foo](https://www.foo.software)** - Foo continuously captures performance audits with Lighthouse, notifies of change, and provides visualization. Users can choose to be notified via email, Slack and PagerDuty. A dashboard with charts show changes by day, week or month and provide detailed reports. Foo is a paid service available with tiers of pricing. Free trials aren't offered at this time, but a [demo dashboard](https://www.foo.software/demo/dashboard) is publicly available for viewing. | |
* **[Foo](https://www.foo.software)** - Foo continuously monitors performance with Lighthouse, monitors for changes, and provides detailed visualization. Users can receive alerts via email, Slack, and PagerDuty with daily, weekly, or monthly reports. Foo is a paid service with several tiers of pricing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
offered a few suggestions to trim it down to the average size here, but feel free to tweak :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @patrickhulce - I took your suggestion and trimmed it even further (removed duplicate monitors
wording). Ready for re-review when you all have time. Thanks again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the quick review @patrickhulce and @exterkamp. |
@patrickhulce - please let me know if there鈥檚 anything else I can do to have this merged. Thanks again for your time! |
Thanks for the quick turnaround everyone. Keep up the good work on this awesome project 馃挆 |
Summary
Adds an integration: Foo.
Thanks in advance 馃檱