Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): Foo integration #8035

Merged
merged 5 commits into from
Apr 8, 2019
Merged

docs(readme): Foo integration #8035

merged 5 commits into from
Apr 8, 2019

Conversation

adamhenson
Copy link
Contributor

Summary

What kind of change does this PR introduce?

Adds an integration: Foo.

Thanks in advance 馃檱

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@adamhenson
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat product!

readme.md Outdated
@@ -280,6 +280,8 @@ This section details services that have integrated Lighthouse data. If you're wo

* **[Fluxguard](https://fluxguard.com/)** - Fluxguard provides website DOM change monitoring orchestrated with Google Puppeteer, and audited by Lighthouse. Fluxguard is a freemium product, with monthly monitoring of up to 75 pages for free.

* **[Foo](https://www.foo.software)** - Foo continuously captures performance audits with Lighthouse, notifies of change, and provides visualization. Users can choose to be notified via email, Slack and PagerDuty. A dashboard with charts show changes by day, week or month and provide detailed reports.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the note that this is a paid product? It also isn't clear if there is any sort of free trial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @patrickhulce. Updated in 9065b24. If you had different phrasing in mind - feel free to let me know.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick response!

readme.md Outdated
@@ -280,6 +280,8 @@ This section details services that have integrated Lighthouse data. If you're wo

* **[Fluxguard](https://fluxguard.com/)** - Fluxguard provides website DOM change monitoring orchestrated with Google Puppeteer, and audited by Lighthouse. Fluxguard is a freemium product, with monthly monitoring of up to 75 pages for free.

* **[Foo](https://www.foo.software)** - Foo continuously captures performance audits with Lighthouse, notifies of change, and provides visualization. Users can choose to be notified via email, Slack and PagerDuty. A dashboard with charts show changes by day, week or month and provide detailed reports. Foo is a paid service available with tiers of pricing. Free trials aren't offered at this time, but a [demo dashboard](https://www.foo.software/demo/dashboard) is publicly available for viewing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* **[Foo](https://www.foo.software)** - Foo continuously captures performance audits with Lighthouse, notifies of change, and provides visualization. Users can choose to be notified via email, Slack and PagerDuty. A dashboard with charts show changes by day, week or month and provide detailed reports. Foo is a paid service available with tiers of pricing. Free trials aren't offered at this time, but a [demo dashboard](https://www.foo.software/demo/dashboard) is publicly available for viewing.
* **[Foo](https://www.foo.software)** - Foo continuously monitors performance with Lighthouse, monitors for changes, and provides detailed visualization. Users can receive alerts via email, Slack, and PagerDuty with daily, weekly, or monthly reports. Foo is a paid service with several tiers of pricing.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offered a few suggestions to trim it down to the average size here, but feel free to tweak :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @patrickhulce - I took your suggestion and trimmed it even further (removed duplicate monitors wording). Ready for re-review when you all have time. Thanks again.

@adamhenson adamhenson changed the title docs: Foo integration docs(readme): Foo integration Apr 7, 2019
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamhenson
Copy link
Contributor Author

Thanks for the quick review @patrickhulce and @exterkamp.

@adamhenson
Copy link
Contributor Author

@patrickhulce - please let me know if there鈥檚 anything else I can do to have this merged. Thanks again for your time!

@paulirish paulirish merged commit 553a7c1 into GoogleChrome:master Apr 8, 2019
@adamhenson
Copy link
Contributor Author

Thanks for the quick turnaround everyone. Keep up the good work on this awesome project 馃挆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants